Case / Audit og refaktoreringAudit and refactor / Privat golfklubPrivate golf club
Code audit og refaktorering af Gentlemen GolfersCode audit and refactor of Gentlemen Golfers
En uvildig second opinion på en AI-bygget golf-app: kernen var solid, strukturen var problemet, og en refaktoreret kodebase gjorde appen klar til at blive færdiggjort.An independent second opinion on an AI-built golf app: the core was solid, the structure was the problem, and a refactored codebase made the app ready to be finished.
ResultaterResults
- Linjer i én fil førLines in one file before
- 12.000+12,000+
- Automatiserede testsAutomated tests
- 166166
- Indledende code auditInitial code audit
- GratisFree
Kontekst
Torben er ikke teknisk uddannet, men ved hjælp af ChatGPT og Cursor fik han alligevel bygget Gentlemen Golfers, en scoring-app til hans private golfklub med 16 medlemmer. Appen fungerede, og klubben stod klar til at tage den i brug fra januar.
Udfordring
Problemet lå under overfladen. Al logikken var samlet i én fil på over 12.000 linjer, og ved siden af den lå en bunke løse SQL-filer uden nogen struktur.
En anden udvikler havde foreslået en større refaktorering (6-8 timer) og en migrering af databaselaget til Prisma (3-5 timer). Torben ville have en uvildig vurdering, før han brugte pengene.
Tilgang
Jeg startede med en gratis indledende code audit. Den viste, at kernen i appen, selve reglerne for turneringsformaterne Stableford, Eclectic og en handicapreguleret variant, var solid og veltestet. Det var strukturen omkring den, der var problemet.
Frem for bare at anbefale en refaktorering byggede jeg en refaktoreret kopi lokalt, så Torben kunne se effekten i praksis:
- Den store fil blev delt op i feature-moduler med rigtig navigation
- Alle databasekald samlet ét sted med genererede typer
- SQL-filerne ryddet op og samlet i en rigtig migrations-mappe
- Løse
any-typer fjernet, og linting sat op - 166 automatiserede tests, plus en end-to-end-test der klikker en hel runde igennem på en Android-emulator
Prisma-migreringen frarådede jeg. Supabase kan selv generere typer til databasen, så at flytte hele databaselaget ville bare have været en dyr omvej uden reel gevinst.
Resultat
Torben fik en fuld rapport og den refaktorerede kodebase med sig. Tre beslutninger, om adgangsstyring og om hvem der kan se live-runder, lod jeg stå åbne og flaggede i stedet til ham, fremfor at træffe dem på hans vegne.
At droppe Prisma sparede ham flere timers betalt arbejde. Og fordi kodebasen nu er struktureret til det, kan han selv vedligeholde og færdiggøre appen med de AI-værktøjer, han allerede bruger.
Context
Torben does not have a technical background, but with help from ChatGPT and Cursor he had built Gentlemen Golfers: a scoring app for his private golf club of 16 members. The app worked, and the club was set to start using it in January.
Challenge
Under the surface the app was hard to keep building on. All of its logic lived in a single file of more than 12,000 lines, next to a large pile of loose SQL files with no structure.
Another developer had proposed a larger refactor (6-8 hours) and a migration of the database layer to Prisma (3-5 hours). Before spending the money, Torben wanted an independent second opinion.
Approach
I started with a free initial code audit. The conclusion was that the core of the app, the rules for the Stableford, Eclectic and handicap-adjusted tournament formats, was solid and well tested. The problem was the structure around it.
Rather than only recommending a refactor, I built a refactored copy locally so Torben could see the effect in practice:
- The large file was split into feature modules with proper navigation
- All database calls were gathered in one place with generated types
- The SQL files were cleaned up into a proper migrations folder
- Loose
anytypes were removed, and linting was set up - 166 automated tests, plus an end-to-end test that clicks through a full round on an Android emulator
I advised against the Prisma migration. Supabase can generate types for the database itself, so moving the whole database layer would have been an expensive detour with no real gain.
Result
Torben got a full report and the refactored codebase. Three decisions about access control and who can see live rounds I left open and flagged to him, rather than making them on his behalf.
Dropping Prisma saved him several hours of paid work. And because the codebase is now structured for it, he can maintain and finish the app himself with the AI tools he already uses.
“Martin gik ud over alle forventninger, da vi kontaktede ham for at få hjælp til at fuldføre vores golf app til vores herregolf klub. Han var tydelig og forståelig omkring de udfordringer vi havde med appen og fik på kort tid etableret et forløb som gjorde at vi kunne komme videre. Vi kan kun kraftigt anbefale Martin.Martin went beyond all expectations when we contacted him for help finishing the golf app for our gentlemen's golf club. He was clear and easy to understand about the challenges we had with the app, and quickly set up a process that let us move forward. We can only warmly recommend Martin.”